Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(1.7.0): add PSA for issue 9267 #974

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Aug 21, 2024
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 422b5cd
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66c5e891f58ed80008bc6406
😎 Deploy Preview https://deploy-preview-974--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@innobead
Copy link
Member

In general, LGTM. However, warnings could be multiple, so we better itemize them. I would like to have @longhorn/doc to suggest the formation.

@derekbit derekbit force-pushed the release-v1.7.0 branch 2 times, most recently from 93823f3 to 11ba492 Compare August 21, 2024 12:28
@derekbit derekbit marked this pull request as ready for review August 21, 2024 12:29
@derekbit derekbit requested a review from a team as a code owner August 21, 2024 12:29
@derekbit
Copy link
Member Author

@jhkrug Can you help review it? Thank you.

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a list to allow easier info scanning. Also, avoid using words like "soon" for better expectation management.

content/docs/1.7.0/important-notes/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit derekbit merged commit ad71fbc into longhorn:master Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants